Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkage_checker: allow linkage via alias #18676

Closed
wants to merge 1 commit into from
Closed

linkage_checker: allow linkage via alias #18676

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but would love any more context as to why?

@cho-m
Copy link
Member Author

cho-m commented Oct 31, 2024 •
edited
Loading

Looks good so far but would love any more context as to why?

Specific scenario was from reversing alias on icu4c so uses_from_macos "icu4c" ends up showing indirect linkage warnings.

Still deciding if this is worth it or just ignoring the macOS dependency information and replacing with on_system :linux, macos: :<os>_or_older (for gnustep-base and r).

May consider latter in Homebrew/homebrew-core#196166

@cho-m
Copy link
Member Author

cho-m commented Oct 31, 2024

Given only 2 formulae, will deal with on Homebrew/core side:

@cho-m cho-m closed this Oct 31, 2024
@cho-m cho-m deleted the linkage_checker-aliases branch October 31, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cho-m @MikeMcQuaid